This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
feat(checkout): CHECKOUT-7899 Update docs of s2s cart api to allow passing source #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1134,6 +1134,11 @@ components: | |||
| description: 'The locale of the cart. Accepts strings of format `xx` or `xx-YY`. Uses the [ISO-639 standard](https://www.iso.org/iso-639-language-codes.html) format.' | |||
| format: ISO-639 | |||
| example: en-US | |||
| source: | |||
There was a problem hiding this comment.
Do we want to expose this publicly / allow developer to call V3 to create Manual Order directly?
I think this will be used by CP only so maybe we don't need to document it for now.
Also I would say it can be confusing to have this in the doc as we don't want people to believe they need to send the source on every requests, especially if we say we only accept MANUAL_INCOMPLETE.
What do you think?
There was a problem hiding this comment.
yes that makes sense. I think again, that keep this a secret now should not cause any issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEVDOCS-]
{Ticket number or summary of work}
What changed?
s2s api (v3) POST /carts now can accept an optional field
sourcein the payload. only one value now are accepted.Anything else?
ping @bigcommerce/team-checkout