Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMS and frequently mass shifts in Unimod #411

Open
ypriverol opened this issue Aug 20, 2024 · 12 comments
Open

OpenMS and frequently mass shifts in Unimod #411

ypriverol opened this issue Aug 20, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@ypriverol
Copy link
Member

Description of feature

@MaLLLiYA @timosachsenberg @jpfeuffer @daichengxin :

We have been analysing some of the datasets and we found some interesting unexpected PTMs (mass shits), most of them are here:

https://unimod.org/modifications_list.php?a=search&value=1&SearchFor=Unidentified+modification+of&SearchOption=Contains&SearchField=

1970 |   | Unknown:162 | Unidentified modification of 162.1258 found in open search | 162.125595 | 162.2267 | H(18) C(8) O(3)

Can we make sure these mods works in OpenMS? Also, Can you let us know @timosachsenberg how you can search with OpenMS tools for a delta mass when the mod is not defined on OpenMS?

@ypriverol ypriverol added the enhancement New feature or request label Aug 20, 2024
@jpfeuffer
Copy link
Collaborator

I think you have to add the mods as CUSTOM0..CUSTOM9 to the unimod.xml in the OpenMS share.

@daichengxin
Copy link
Collaborator

image
In search engine adapter, there is a mass_offsets paramter. Is it applicable?

@ypriverol
Copy link
Member Author

I think you have to add the mods as CUSTOM0..CUSTOM9 to the unimod.xml in the OpenMS share.

But can this be done dynamically, or we need to add this inside OpenMS and wait for the release?

@jpfeuffer
Copy link
Collaborator

I think this is a comet specific extension, right?
It sounds like this is a MS1 offset only. I am not sure if it will consider those offsets for every fragment.

If this is what you want, it might work.

@ypriverol
Copy link
Member Author

This is a good point, if this mass shift is for unexpected PTM - for example 1970 | | Unknown:162 | Unidentified modification of 162.1258 found in open search | 162.125595 | 162.2267 | H(18) C(8) O(3) in order to identify those peptides, the precursor mass offset should define that mass offset but also the fragment tolerance?

@timosachsenberg
Copy link

by default search engines assume that the mass shift on the precursor is also observed on the fragments carrying the PTM (e.g., no neutral loss on the PTM is assumed).

@jpfeuffer
Copy link
Collaborator

I think you have to add the mods as CUSTOM0..CUSTOM9 to the unimod.xml in the OpenMS share.

But can this be done dynamically, or we need to add this inside OpenMS and wait for the release?

This can be done dynamically.

@jpfeuffer
Copy link
Collaborator

jpfeuffer commented Sep 13, 2024

by default search engines assume that the mass shift on the precursor is also observed on the fragments carrying the PTM (e.g., no neutral loss on the PTM is assumed).

@timosachsenberg But the "mass_offsets" parameter is not for a PTM. You cannot associate a specific AA to that mass_offset, so it wont know which fragments would hold this mass_offset. Therefore I assume this is an MS1-only feature of Comet.

@timosachsenberg
Copy link

Agree. I really think easiest is to modify the unimod.xml entries for the custom mods. Then it is automatically understood by all tools.

If we can't modify unimod.xml we need to add parameters to all tools that should understand the custom modification (because otherwise peptide masses are not calculated correctly in downstream tools).

@ypriverol
Copy link
Member Author

My point is more generic: some of these "custom" pipelines, MOD mass-shifts should be easy to pass ass custom mods without the need to recompile the entire OpenMS pipeline. If you think, it is supported, then we can try one example and see if really custom mass shifts can be analyzed in quantms.

@jpfeuffer
Copy link
Collaborator

jpfeuffer commented Sep 13, 2024

Yes it's supported. You will need to add the custom unimod.xml to every step though. You can just add the XML entry with

echo "<modification name="foo" mass=123.4/>" >> Openmsshare/unimod.xml

No, it is not easy to "just" support this in the whole pipeline because you would need to encode everything about that modification in every output file you write to make sure that the next tool understands what this mass shift is. Either you will have super verbose files or you need a common file like that unimod.xml

@ypriverol
Copy link
Member Author

I was thinking and mentioned to Timo that it would be good to support mass shifts as mods in OpenMS. The idea is that we can add a mass shift and keep it in the entire workflow rather than the unimod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants