rf(context): Move file tree, schema, and issues into context.dataset #2066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset issues sensibly accumulate on the long-lived dataset object, instead of the ephemeral context object.
dataset.tree
is defined by the schema, and also makes sense there.I think
walk.ts
demonstrates this well. The dataset context provides the files to be iterated over, and a new context can be generated with just the current file and the dataset context.There's still room to pre-allocate a
context.subject
object and pass that through, but this is enough of a change for one PR, IMO.This will help focus #2057 on the specific changes needed for those issues.