feat: Track files referenced by other files to identify orphans #2057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the legacy checks:
The approach is to add a
.viewed
boolean field onBIDSFile
and trip it when either of the inheritance principlewalkBack()
or the expression languageexists()
functions finds the file.Note that apparently we had a lot of false negatives in the legacy validator, and SIDECAR_WITHOUT_DATAFILE is causing failures of examples.
Should wait on #2064, #2066 and bids-standard/bids-examples#461.
Diff specific to this PR: bids-standard/bids-validator@2ecf188...e5aeeca