Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $notification available in routeNotificationForFcm #26

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Make $notification available in routeNotificationForFcm #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50fcad6
Make $notification available in routeNotificationForFcm
chimit Oct 12, 2018
773b8fb
Update readme
chimit Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ When sending to specific device, make sure your notifiable entity has `routeNoti
/**
* Route notifications for the FCM channel.
*
* @param \Illuminate\Notifications\Notification $notification
* @return string
*/
public function routeNotificationForFcm()
public function routeNotificationForFcm($notification)
{
return $this->device_token;
}
Expand Down
2 changes: 1 addition & 1 deletion src/FcmChannel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function send($notifiable, Notification $notification)
$message = $notification->toFcm($notifiable);

if (is_null($message->getTo()) && is_null($message->getCondition())) {
if (! $to = $notifiable->routeNotificationFor('fcm')) {
if (! $to = $notifiable->routeNotificationFor('fcm', $notification)) {
return;
}

Expand Down