Make $notification available in routeNotificationForFcm

[chimit]

No description provided.

[benwilkins]

Why do you need $notification here? The notifiable entity should just be determining where the notification is going, which shouldn't be dependent on the notification itself. Also, this would present breaking changes.

[chimit]

Because $notification is available in other delivery channels. In my case, I need it to filter recipients:

class Group extends Model
{
    use Notifiable;

    public function users()
    {
        return $this->belongsToMany('App\Models\User')
                    ->withTimestamps();
    }

    public function routeNotificationForFcm($notification)
    {
        return $this->load(['users' => function ($query) use ($notification) {
            // Do not send push notification to the author
            $query->where('users.id', '<>', $notification->user->id);
        }, 'users.devices'])
            ->users
            ->pluck('devices')
            ->collapse()
            ->pluck('fcm_token')
            ->all();
    }
}

I send notifications to groups of users instead of users to prevent multiple requests to the Firebase. Related to this issue: #2

[benwilkins]

I'll approve it. It will have to be version 3.0 since it introduces breaking changes.