power: crelay: clean up and enable use of multiple compatible devices #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Love it! |
Comment on lines
+36
to
37
| let info = await execAsync(`crelay -i`); | ||
| console.log(info.stdout); |
There was a problem hiding this comment.
Suggested change
| let info = await execAsync(`crelay -i`); | |
| console.log(info.stdout); | |
| console.log((await execAsync(`crelay -i`)).stdout); |
| @@ -35,18 +44,17 @@ export class Crelay implements Power { | |||
| // Power on the DUT | |||
| async on(voltage?: number): Promise<void> { | |||
| console.log(`Powering on DUT...`); | |||
| await execAsync(`crelay ${this.relayId} ${this.connOn}`); | |||
| await execAsync(`${this.crelayCmd} ${this.connOn}`); | |||
There was a problem hiding this comment.
connOn doesn't give a lot of information what this variable would be? Suggest changing it to something more descriptive.
Change-type: minor Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/crelay-serial
branch
from
a246881 to
0706a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for specifying the serial number of the crelay compatible relay being used to control power - for the case where multiple connected devices are picked up by crelay tooling (e.g an FTDI usb to serial adapter)
supersedes #81
Change-type: minor