Crelay serial #81
Closed
Crelay serial #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perezmeyer
force-pushed
the
crelay_serial
branch
from
2a1fd47 to
33106e3
Compare
|
@vipulgupta2048 @rcooke-warwick note that this PR builds upon the precedent one, #80 |
This allows specifying which device to use when crelay detects more than one on a system. Can happen when a FTDI USB-serial converter is present. Changelog-Entry: crelay: allow crelay to specify the serial number Signed-By: Lisandro Pérez Meyer <[email protected]>
vipulgupta2048
force-pushed
the
crelay_serial
branch
from
33106e3 to
518d342
Compare
|
superseded by #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vipulgupta2048 this patch still has a problem: if the serial number is not specified then
-sshould not be passed to the command. At this pint my lack of JS knowledge beats me.