chore: Allow unbonding time to be min unbonding value #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
force-pushed
the
gai/allow-min-unbonding-time
branch
from
481e2b2
to
b152dea
Compare
gitferry
requested review from
Lazar955,
RafilxTenfen,
KonradStaniec and
jrwbabylonlab
and removed request for
a team
| @@ -110,6 +111,10 @@ func (ms msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdatePara | |||
| } | |||
|
|
|||
| ctx := sdk.UnwrapSDKContext(goCtx) | |||
| if req.Params.CheckpointFinalizationTimeout != ms.k.GetParams(ctx).CheckpointFinalizationTimeout { | |||
There was a problem hiding this comment.
can we add a comment here on why it can't be changed?
jrwbabylonlab
approved these changes
Nov 20, 2024
KonradStaniec
approved these changes
Nov 20, 2024
| @@ -206,6 +201,6 @@ func ValidateParsedMessageAgainstTheParams( | |||
| return &ParamsValidationResult{ | |||
| StakingOutputIdx: stakingOutputIdx, | |||
| UnbondingOutputIdx: 0, // unbonding output always has only 1 output | |||
| MinUnbondingTime: minUnbondingTime, | |||
| MinUnbondingTime: parameters.MinUnbondingTimeBlocks, | |||
There was a problem hiding this comment.
as we no longer calculate valid MinUnbondingTime in this functions, we can probably remove this field from ParamsValidationResult . (the caller has access to parameters.MinUnbondingTimeBlocks eitherway)
There was a problem hiding this comment.
Good point. Fixed in 6b4abc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263. In particular,
checkpointFinalizationTimeoutcan never be changed in the update params handler of the btccheckpoint moduleminUnbondingTimecan not be set to a value less than or equal tocheckpointFinalizationTimeoutin the update params handler of the btcstaking moduleunbondingTimeof a delegation to be set to a value equals tominUnbondingTime