Minimum unbonding time check is not inclusive

[filippos47]

Version: v0.8.0

2024-11-25T20:10:14.439988Z	error	invalid unbonding time	{"min_unbonding_time": 2, "got_unbonding_time": 2}

Still looking at this one.

[filippos47]

This is actually a btc-staker bug. The covenant emulator expects that delegations' unbonding time > min unbonding time: https://github.com/babylonlabs-io/covenant-emulator/blame/cc6d93fe8819ee4ae4536ef54666368a501e0194/covenant/covenant.go#L123

In the latest btc-staker version (v0.12.0), we seem to be breaking this condition: https://github.com/babylonlabs-io/btc-staker/pull/99/files#diff-62e1d8d486f4b80fe483f59d798de6cb39548c220b711fbcdac69b3d9730ff9bR118

[KonradStaniec]

This actually covenant emulator bug, in recent babylon version we introducend change that made it possible to setup unbonding time to min unbonding time - babylonlabs-io/babylon#278

Though the thing is parmeters needs to be set that way that MinUnbondingTime > CheckpointFinalizationTimeout, and we actually check it during gov proposals.

[KonradStaniec]

fixed by: #40