Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove libraries from unitest #14

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Conversation

DimEvil
Copy link
Collaborator

@DimEvil DimEvil commented Apr 3, 2024

small improvement by Dimi (with support of Pieter)

@DimEvil DimEvil linked an issue Apr 3, 2024 that may be closed by this pull request
@PietrH PietrH requested a review from wlangera April 3, 2024 07:46
@DimEvil DimEvil requested a review from PietrH April 3, 2024 07:46
@PietrH PietrH marked this pull request as draft April 3, 2024 07:47
@PietrH
Copy link
Collaborator

PietrH commented Apr 3, 2024

You don't need to load libraries in unit tests, but instead use the format of package::function()

This is the same way in function scripts.

@DimEvil DimEvil marked this pull request as ready for review April 3, 2024 08:11
@PietrH PietrH removed their request for review April 3, 2024 08:11
Copy link
Collaborator

@wlangera wlangera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks guys great work

@PietrH PietrH merged commit 35d8b55 into main Apr 3, 2024
1 of 7 checks passed
@PietrH PietrH deleted the 6-remove-library-calls-from-tests branch April 3, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove library() calls from tests
3 participants