Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove here dependency from unit tests #15

Closed
PietrH opened this issue Apr 3, 2024 · 1 comment · Fixed by #19
Closed

remove here dependency from unit tests #15

PietrH opened this issue Apr 3, 2024 · 1 comment · Fixed by #19
Assignees
@PietrH
Labels
bug Something isn't working

Comments

@PietrH
Copy link
Collaborator

PietrH commented Apr 3, 2024

There is a here dependency in the unit tests, form when they were still markdown files in a previous version of the repo (that was an analysis script, not an R package).

This source() call is not neccesairy because the package is loaded when the tests are run, and because here is missing from DESCRIPTION, it'll fail.
@PietrH PietrH self-assigned this Apr 3, 2024
@PietrH PietrH added the bug Something isn't working label Apr 3, 2024
@PietrH
Copy link
Collaborator Author

PietrH commented Apr 3, 2024

Maybe better to wait until after #14 so we don't get a conflict

@PietrH PietrH linked a pull request Apr 3, 2024 that will close this issue
15 remove here dependency from unit tests #19
Merged
@PietrH PietrH mentioned this issue Apr 3, 2024
Merged
@PietrH PietrH closed this as completed in #19 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PietrH PietrH

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

15 remove here dependency from unit tests b-cubed-eu/gcube
1 participant
@PietrH