forked from ivy-jh/skribble-connector
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MARP-1481 convert to Ivy 12 #11
Merged
tvtphuc-axonivy
merged 6 commits into
master
from
feature/MARP-1481-Update-connectors-to-v12
Nov 27, 2024
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
98af78d
MARP-1481 convert to Ivy 12
tvtphuc-axonivy a732db7
MARP-1481 Update ci.yml and release.yml
tvtphuc-axonivy dc39019
MARP-1481 update pom file and persist file issue
tvtphuc-axonivy 235e0d9
MARP-1481 Handle Feedbacks
tvtphuc-axonivy 6fd90f3
MARP-1481 reformat code
tvtphuc-axonivy 0fba4c9
MARP-1481 Handle Feedbacks
tvtphuc-axonivy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,53 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <projectDescription> | ||
| <name>skribble-connector-demo</name> | ||
| <comment></comment> | ||
| <projects> | ||
| </projects> | ||
| <buildSpec> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.dataClasses.ui.ivyDataClassBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.process.ui.ivyWebServiceProcessClassBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.jdt.core.javabuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.wst.common.project.facet.core.builder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.ide.ivyModelValidationBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.m2e.core.maven2Builder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| </buildSpec> | ||
| <natures> | ||
| <nature>ch.ivyteam.ivy.project.IvyProjectNature</nature> | ||
| <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature> | ||
| <nature>org.eclipse.jem.workbench.JavaEMFNature</nature> | ||
| <nature>org.eclipse.jdt.core.javanature</nature> | ||
| <nature>org.eclipse.m2e.core.maven2Nature</nature> | ||
| <nature>org.eclipse.jem.beaninfo.BeanInfoNature</nature> | ||
| <nature>org.eclipse.wst.common.project.facet.core.nature</nature> | ||
| <nature>org.eclipse.wst.jsdt.core.jsNature</nature> | ||
| </natures> | ||
| </projectDescription> | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <projectDescription> | ||
| <name>skribble-connector-demo</name> | ||
| <comment></comment> | ||
| <projects> | ||
| </projects> | ||
| <buildSpec> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.dataClasses.ui.ivyDataClassBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.process.ui.ivyWebServiceProcessClassBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.jdt.core.javabuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.wst.common.project.facet.core.builder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.dialog.form.build.ivyDialogFormBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>ch.ivyteam.ivy.designer.ide.ivyModelValidationBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| <buildCommand> | ||
| <name>org.eclipse.m2e.core.maven2Builder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> | ||
| </buildSpec> | ||
| <natures> | ||
| <nature>ch.ivyteam.ivy.project.IvyProjectNature</nature> | ||
| <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature> | ||
| <nature>org.eclipse.jem.workbench.JavaEMFNature</nature> | ||
| <nature>org.eclipse.jdt.core.javanature</nature> | ||
| <nature>org.eclipse.m2e.core.maven2Nature</nature> | ||
| <nature>org.eclipse.jem.beaninfo.BeanInfoNature</nature> | ||
| <nature>org.eclipse.wst.common.project.facet.core.nature</nature> | ||
| </natures> | ||
| </projectDescription> |
This file was deleted.
Oops, something went wrong.
5 changes: 2 additions & 3 deletions
5
skribble-connector-demo/.settings/ch.ivyteam.ivy.designer.prefs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| ch.ivyteam.ivy.designer.preferences.DataClassPreferencePage\:DEFAULT_DATA_CLASS=com.axonivy.connector.skribble.demo.Data | ||
| ch.ivyteam.ivy.designer.preferences.DataClassPreferencePage\:DEFAULT_NAMESPACE=com.axonivy.connector.skribble.demo | ||
| ch.ivyteam.ivy.project.preferences\:PRIMEFACES_VERSION=11 | ||
| ch.ivyteam.ivy.project.preferences\:PROJECT_VERSION=100000 | ||
| ch.ivyteam.ivy.project.preferences\:PRIMEFACES_VERSION=13 | ||
| ch.ivyteam.ivy.project.preferences\:PROJECT_VERSION=120001 | ||
| eclipse.preferences.version=1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| eclipse.preferences.version=1 | ||
| org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled | ||
| org.eclipse.jdt.core.compiler.codegen.targetPlatform=17 | ||
| org.eclipse.jdt.core.compiler.compliance=17 | ||
| org.eclipse.jdt.core.compiler.codegen.targetPlatform=21 | ||
| org.eclipse.jdt.core.compiler.compliance=21 | ||
| org.eclipse.jdt.core.compiler.problem.assertIdentifier=error | ||
| org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled | ||
| org.eclipse.jdt.core.compiler.problem.enumIdentifier=error | ||
| org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=warning | ||
| org.eclipse.jdt.core.compiler.release=enabled | ||
| org.eclipse.jdt.core.compiler.source=17 | ||
| org.eclipse.jdt.core.compiler.source=21 |
21 changes: 10 additions & 11 deletions
21
skribble-connector-demo/.settings/org.eclipse.wst.common.component
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0"> | ||
| <wb-module deploy-name="skribble-connector-demo"> | ||
| <wb-resource deploy-path="/" source-path="/webContent" tag="defaultRootSource"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src_hd"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src_wsproc"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src_dataClasses"/> | ||
| <property name="context-root" value="skribble-connector-demo"/> | ||
| <property name="java-output-path" value="/skribble-connector-demo/target/classes"/> | ||
| </wb-module> | ||
| </project-modules> | ||
| <?xml version="1.0" encoding="UTF-8"?><project-modules id="moduleCoreId" project-version="1.5.0"> | ||
| <wb-module deploy-name="skribble-connector-demo"> | ||
| <wb-resource deploy-path="/" source-path="/webContent" tag="defaultRootSource"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src_wsproc"/> | ||
| <wb-resource deploy-path="/WEB-INF/classes" source-path="/src_dataClasses"/> | ||
| <property name="context-root" value="skribble-connector-demo"/> | ||
| <property name="java-output-path" value="/skribble-connector-demo/target/classes"/> | ||
| </wb-module> | ||
| </project-modules> |
14 changes: 6 additions & 8 deletions
14
skribble-connector-demo/.settings/org.eclipse.wst.common.project.facet.core.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <faceted-project> | ||
| <fixed facet="wst.jsdt.web"/> | ||
| <installed facet="java" version="17"/> | ||
| <installed facet="jst.web" version="3.0"/> | ||
| <installed facet="wst.jsdt.web" version="1.0"/> | ||
| <installed facet="jst.jsf" version="2.1"/> | ||
| </faceted-project> | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <faceted-project> | ||
| <installed facet="java" version="21"/> | ||
| <installed facet="jst.web" version="3.0"/> | ||
| <installed facet="jst.jsf" version="2.1"/> | ||
| </faceted-project> |
1 change: 0 additions & 1 deletion
1
skribble-connector-demo/.settings/org.eclipse.wst.jsdt.ui.superType.container
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
skribble-connector-demo/.settings/org.eclipse.wst.jsdt.ui.superType.name
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
skribble-connector-demo/dataclasses/com/axonivy/connector/skribble/demo/Data.d.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "$schema" : "https://json-schema.axonivy.com/data-class/12.0.0/data-class.json", | ||
| "simpleName" : "Data", | ||
| "namespace" : "com.axonivy.connector.skribble.demo", | ||
| "isBusinessCaseData" : false | ||
| } |
2 changes: 0 additions & 2 deletions
2
skribble-connector-demo/dataclasses/com/axonivy/connector/skribble/demo/Data.ivyClass
This file was deleted.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
...e-connector-demo/dataclasses/com/axonivy/connector/skribble/demo/SampleProcessData.d.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "$schema" : "https://json-schema.axonivy.com/data-class/12.0.0/data-class.json", | ||
| "simpleName" : "SampleProcessData", | ||
| "namespace" : "com.axonivy.connector.skribble.demo", | ||
| "isBusinessCaseData" : false, | ||
| "fields" : [ { | ||
| "name" : "createSignatureRequest", | ||
| "type" : "com.skribble.api.v2.client.CreateSignatureRequest", | ||
| "modifiers" : [ "PERSISTENT" ] | ||
| }, { | ||
| "name" : "signatureRequest", | ||
| "type" : "com.skribble.api.v2.client.SignatureRequest", | ||
| "modifiers" : [ "PERSISTENT" ] | ||
| }, { | ||
| "name" : "nextView", | ||
| "type" : "String", | ||
| "modifiers" : [ "PERSISTENT" ] | ||
| } ] | ||
| } |
8 changes: 0 additions & 8 deletions
8
...connector-demo/dataclasses/com/axonivy/connector/skribble/demo/SampleProcessData.ivyClass
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
...-connector-demo/src_hd/com/axonivy/connector/skribble/demo/Overview/Overview.rddescriptor
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the dev.yml as well; to consume @v5 with 13.1 artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @ivy-rew , I will update it