Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARP-1481 convert to Ivy 12 #11

Merged
merged 6 commits into from
Nov 27, 2024
Merged

MARP-1481 convert to Ivy 12 #11

merged 6 commits into from
Nov 27, 2024

Conversation

tvtphuc-axonivy
Copy link

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Test Results

4 tests  ±0   4 ✅ ±0   10s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 0fba4c9. ± Comparison against base commit 0577764.

♻️ This comment has been updated with latest results.

ivy-rew
ivy-rew reviewed Nov 25, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
Comment on lines 13 to 15
with:
javaVersion: 21
mvnVersion: 3.9.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of writing these new defaults into each and every connector we're upgrading we should rather update the shared pipelines .... by introducing a new version with the new defaults.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Reguel, I will try to introduce a new version with the new defaults.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks @tvtphuc-axonivy
You will find the pipelines here: https://github.com/axonivy-market/github-workflows/blob/master/.github/workflows/ci.yml
I can't remember who contributed to them the last time, but at least one of your mates should have some experience here which you may involve.

ivy-rew
ivy-rew reviewed Nov 26, 2024
View reviewed changes
.github/workflows/ci.yml
@@ -9,4 +9,4 @@ on:

jobs:
build:
uses: axonivy-market/github-workflows/.github/workflows/ci.yml@v4
uses: axonivy-market/github-workflows/.github/workflows/ci.yml@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the dev.yml as well; to consume @v5 with 13.1 artifacts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @ivy-rew , I will update it

@nqhoan-axonivy
Copy link

Hi @tvtphuc-axonivy when uploading a doc to sign in the 'Upload document for signing' process, still 1 error at writeBinary() api appear in the project
image

nqhoan-axonivy
nqhoan-axonivy approved these changes Nov 27, 2024
View reviewed changes
Copy link

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivy-rew ivy-rew requested a review from ivy-jh November 27, 2024 08:06
@tvtphuc-axonivy tvtphuc-axonivy merged commit d7badeb into master Nov 27, 2024
7 checks passed
@tvtphuc-axonivy tvtphuc-axonivy deleted the feature/MARP-1481-Update-connectors-to-v12 branch November 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-rew ivy-rew ivy-rew left review comments

@nqhoan-axonivy nqhoan-axonivy nqhoan-axonivy approved these changes

@ivy-jh ivy-jh Awaiting requested review from ivy-jh

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvtphuc-axonivy @nqhoan-axonivy @ivy-rew