-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Java and Maven version, using 21+3.9 for dev #26
Conversation
alternative approach for #25 |
@@ -19,5 +19,7 @@ jobs: | |||
uses: axonivy-market/github-workflows/.github/workflows/ci.yml@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ivy-rew
Should we change the ci.yml
uses with a new tag name? e.g. v3?
When we merge it into the master branch, do we run git tag
commands manually or have a job to do the tagged task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can decide on this, though I'd suggest to keep the 'v2' tag for now, as I think there is no functional/breaking change in it and we we can 'spare' the roll-out effort to update all the consumers to the new version.
Once the thing is on the master branch you can tag it, either using the github-ui or with git commands in your terminal. There is no automated job for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you take the lead on merging this and tagging it @phhung-axonivy ? Or shall I apply it?
Or do we have further need for discussion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You introduced two new inputs in the ci.yml file, and you used them in the dev.yml file.
With ci.yml@v2, these inputs have not been introduced yet. That's the reason why I ask you to use a new tag v3.
If it's not taking too much of your time, please apply it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll introduce it and consume it by example in msgraph and a-trust ... so you can use this as copy example how to proceed in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @ivy-rew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 is introduced: the adaption can be copied from here ... I think you can share this way to go with the team and apply it to all artifacts in the market.
make Java and Maven version configurable, so that we can consume newer versions on the LE 11.4 dev-pipeline.