Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Java and Maven version, using 21+3.9 for dev #26

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Jul 22, 2024

make Java and Maven version configurable, so that we can consume newer versions on the LE 11.4 dev-pipeline.

@ivy-rew ivy-rew requested a review from phhung-axonivy July 22, 2024 13:41
@ivy-rew ivy-rew marked this pull request as ready for review July 22, 2024 13:42
@ivy-rew
Copy link
Member Author

ivy-rew commented Jul 22, 2024

alternative approach for #25

@@ -19,5 +19,7 @@ jobs:
uses: axonivy-market/github-workflows/.github/workflows/ci.yml@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivy-rew
Should we change the ci.yml uses with a new tag name? e.g. v3?
When we merge it into the master branch, do we run git tag commands manually or have a job to do the tagged task?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can decide on this, though I'd suggest to keep the 'v2' tag for now, as I think there is no functional/breaking change in it and we we can 'spare' the roll-out effort to update all the consumers to the new version.

Once the thing is on the master branch you can tag it, either using the github-ui or with git commands in your terminal. There is no automated job for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you take the lead on merging this and tagging it @phhung-axonivy ? Or shall I apply it?
Or do we have further need for discussion?

Copy link

@phhung-axonivy phhung-axonivy Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You introduced two new inputs in the ci.yml file, and you used them in the dev.yml file.
With ci.yml@v2, these inputs have not been introduced yet. That's the reason why I ask you to use a new tag v3.
If it's not taking too much of your time, please apply it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll introduce it and consume it by example in msgraph and a-trust ... so you can use this as copy example how to proceed in the future

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ivy-rew

Copy link
Member Author

@ivy-rew ivy-rew Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 is introduced: the adaption can be copied from here ... I think you can share this way to go with the team and apply it to all artifacts in the market.

@ivy-rew ivy-rew merged commit c9735b5 into master Jul 23, 2024
@ivy-rew ivy-rew deleted the dev114 branch July 23, 2024 08:24
@ivy-rew ivy-rew changed the title refactor: configurable java-version, using 21 for dev configurable java and maven version, using 21+3.9 for dev Jul 26, 2024
@ivy-rew ivy-rew changed the title configurable java and maven version, using 21+3.9 for dev configurable Java and Maven version, using 21+3.9 for dev Jul 26, 2024
@ivy-rew ivy-rew changed the title configurable Java and Maven version, using 21+3.9 for dev Configurable Java and Maven version, using 21+3.9 for dev Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants