Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MARP-633 upgrade to Ivy 11.3 #99

Closed
wants to merge 2 commits into from
Closed

Conversation

ny-huynh
Copy link

No description provided.

@ivy-rew
Copy link
Member

ivy-rew commented Jul 22, 2024

I think we should avoid the introduction of new release trains as long as possible; to lower the maintenance efforts.
With the #101 we have a solution to make the build pass ... so there's no longer a necessity to converter the projects on master, until we really like to do this.

Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you outline the benefits of this migration before the LTS12 release?
shouldn't we just make the dev builds pass instead?

@ptanhaxon
Copy link

ptanhaxon commented Jul 23, 2024

can you outline the benefits of this migration before the LTS12 release? shouldn't we just make the dev builds pass instead?

Hi @ivy-rew ,
The idea of the migration comes up from MARP-214,

With the upcoming ivy release 11.3 Primefaces 13 will be introduced.
We must guarantee that all connectors, utils, demos from the market place are still working with PF13.

We intend to make sure the demo projects are compatible with the new Ivy version which use PF 13.

cc @ivy-sgi , @kimthanh175

@ivy-sgi
Copy link
Member

ivy-sgi commented Jul 23, 2024

Hi @ivy-rew ! I think we need to separate the "11.3-primeface"-customization of new connectors and how and when this should be published on the market website. Just let me know how you did this in previous versions and I'll spread the word ;) We have 70+ connectors so we are very happy that team Atomic supports with this topic.
@kimthanh175 FYI

@ivy-rew
Copy link
Member

ivy-rew commented Jul 23, 2024

Hi @ivy-rew , The idea of the migration comes up from MARP-214,

With the upcoming ivy release 11.3 Primefaces 13 will be introduced.
We must guarantee that all connectors, utils, demos from the market place are still working with PF13.

We intend to make sure the demo projects are compatible with the new Ivy version which use PF 13.

Thank you for the explanation @ptanhaxon. And glad to see you involved @ivy-sgi to navigate these changes. In order to test PF13, we will need a working dev-pipeline. So working on the PF13 compatibility before the pipeline works seems wrong as we won't be able to differ problems arising by using the latest core from the Primefaces issues.

Today the dev-pipeline is broken ... I'm in discussion with @phhung-axonivy to make them functional again: axonivy-market/github-workflows#26

Once the 'dev' builds are back to stable we can safely verify the PF13 compatibility. Here we could follow multiple paths; I'd proceed as follows:

  1. create a new branch (e.g. PF13)
  2. convert all projects from master using the designer 11.3 that contains PF13 -> commit this
  3. you'll get feedback form the dev-pipeline on this branch whether PF13 'works'

If there are no issues with PF13, I don't see any benefits of merging this change back to 'master'. As we will have to run subsequent migrations anyway (11.4). If you have to manually adjust code to make the project compatible though, when we should commit these changes with distinct commits. Feed the change back to master and introduce a release/10.0 branch where the previous master HEAD commit resides.

@ivy-rew
Copy link
Member

ivy-rew commented Jul 23, 2024

We have 70+ connectors so we are very happy that team Atomic supports with this topic. @kimthanh175

Sure great that Atomic supports us here. Nevertheless please keep the repo's main contributors in the loop if you supply PRs. Just like team Octopus does nowadays. I sort of stumbled over this change by accident and was quite astonished to not be involved.

@ptanhaxon
Copy link

Agree @ivy-rew ! We will close this PR and create the PF-13 branch & request for reviewing the changes. Once the dev-pipline is ready, we can process further steps.

@ny-huynh ny-huynh closed this Jul 23, 2024
@ny-huynh ny-huynh deleted the features/MARP-633 branch July 23, 2024 07:29
@ivy-rew
Copy link
Member

ivy-rew commented Jul 23, 2024

dev-pipeline is ready #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants