fix: add UnsupportedSigningAlgorithmInterceptor to all sigV4a services #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
ianbotsf
approved these changes
Mar 6, 2024
lauzadis
approved these changes
Mar 6, 2024
| } | ||
|
|
||
| // Needs to happen after the SigV4AsymmetricTraitCustomization (-60), which adds the sigV4a trait to models missing it | ||
| override val order: Byte = -50 |
There was a problem hiding this comment.
question: Why not just leave it as the default (zero)?
Comment on lines
28
to
30
| // Set to true rather than looking for sigV4a in the model here because this integration would be filtered out | ||
| // before the application of the trait is done for some services via SigV4AsymmetricTraitCustomization. | ||
| // See: CodegenVisitor |
There was a problem hiding this comment.
This should be a simple fix and I see we have a FIXME already in CodegenVisitor, if you have the time I would recommend including it in this PR. Then we don't need the hardcoded true and we can tighten the conditional.
CodegenVisitor.kt
integrations = ServiceLoader.load(KotlinIntegration::class.java, classLoader)
.onEach { integration -> LOGGER.info("Loaded KotlinIntegration: ${integration.javaClass.name}") }
.sortedBy(KotlinIntegration::order)
...
for (integration in integrations) {
if (integration.enabledForService(resolvedModel, settings)) {
resolvedModel = integration.preprocessModel(resolvedModel, settings)
}
}
|
|
A new generated diff is ready to view.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
The
UnsupportedSigningAlgorithmInterceptor, which deals with the default signer not supporting sigV4a was only being applied to a hard coded list of services, now the interceptor is applied based on the sigV4a trait.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.