fix: codegen visitor filtering bug #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
lauzadis
approved these changes
Mar 7, 2024
| .sortedBy(KotlinIntegration::order) | ||
| .toMutableList() |
There was a problem hiding this comment.
design suggestion: instead of making this a MutableList, it might be better to have configuredIntegrations and enabledIntegrations (configuredIntegrations - disabledIntegrations)
There was a problem hiding this comment.
example:
configuredIntegrations = ServiceLoader.load(KotlinIntegration::class.java, classLoader)
...
val enabledIntegrations = configuredIntegrations.mapNotNull { integration ->
if (integration.enabledForService(resolvedModel, settings)) {
println("Executing KotlinIntegration: ${integration.javaClass.name}")
resolvedModel = integration.preprocessModel(resolvedModel, settings)
integration
} else {
null
}
}
|
|
||
| // Needs to be true due to the way integrations are filtered out before application and sigV4a customization. | ||
| // See 'CodegenVisitor' & 'SigV4AsymmetricTraitCustomization' | ||
| override fun enabledForService(model: Model, settings: KotlinSettings): Boolean = true |
There was a problem hiding this comment.
note: There is one more of these hardcoded true in UnsupportedSigningAlgorithmIntegration, do you plan to change that one separately?
There was a problem hiding this comment.
Yes, that one is in aws-sdk-kotlin. The change is in a pull request here: awslabs/aws-sdk-kotlin#1245
ianbotsf
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
The
CodegenVisitorwas filtering out integrations that would otherwise not be because of the filtering didn't take into account model pre-processing changes that would happenDescription of changes
Filtering was updated so Integrations take into account previous model pre-processing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.