fix: only enable aws-chunked content encoding for S3
#1224
Conversation
| @@ -20,7 +21,7 @@ import software.amazon.smithy.model.shapes.ServiceShape | |||
| * Set default signing attributes in the execution context (which ultimately becomes the signing context) for S3. | |||
| */ | |||
| class S3SigningConfig : KotlinIntegration { | |||
| // auth schemes are de-duped by taking the last one registered | |||
| // integrations are de-duped by taking the last one registered | |||
There was a problem hiding this comment.
question: is this comment now correct? I wasn't sure why auth schemes were relevant here
There was a problem hiding this comment.
No, I don't think this comment is correct for integrations. All of the registered integrations are "taken" and there is no possibility of duplication.
The comment was correct for auth schemes and I believe it was referring to the order value defined below, indicating that whatever auth scheme this integration registered should be the one that's taken because it'll be the last one (unless a user overrides it even later in client config). That said, I don't see this integration registering an auth scheme so I'm not sure how it's relevant.
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
| @@ -20,7 +21,7 @@ import software.amazon.smithy.model.shapes.ServiceShape | |||
| * Set default signing attributes in the execution context (which ultimately becomes the signing context) for S3. | |||
| */ | |||
| class S3SigningConfig : KotlinIntegration { | |||
| // auth schemes are de-duped by taking the last one registered | |||
| // integrations are de-duped by taking the last one registered | |||
There was a problem hiding this comment.
No, I don't think this comment is correct for integrations. All of the registered integrations are "taken" and there is no possibility of duplication.
The comment was correct for auth schemes and I believe it was referring to the order value defined below, indicating that whatever auth scheme this integration registered should be the one that's taken because it'll be the last one (unless a user overrides it even later in client config). That said, I don't see this integration registering an auth scheme so I'm not sure how it's relevant.
|
A new generated diff is ready to view. |
|
|
A new generated diff is ready to view. |
This PR disables
aws-chunkedcontent encoding for all services by default, except S3. It also adds support for a newEnableAwsChunkedsigning attribute which controls enablingaws-chunkedcontent encoding.Issue #
closes #1217
Description of changes
This change is required because S3 is the only service which explicitly supports
aws-chunkedcontent encoding.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.