fix: customization for x-amz-content-sha256 header bindings #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A new generated diff is ready to view.
|
ianbotsf
approved these changes
Feb 16, 2024
| override fun render(ctx: ProtocolGenerator.GenerationContext, op: OperationShape, writer: KotlinWriter) { | ||
| val member = getXAmzContentSha256HeaderMember(ctx, op)!! | ||
| writer.withBlock("input.${member.defaultName()}?.let {", "}") { | ||
| writer.write("op.context[#1T.#2T] = #2T.Precalculated(it)", RuntimeTypes.Auth.Signing.AwsSigningCommon.AwsSigningAttributes, RuntimeTypes.Auth.Signing.AwsSigningCommon.HashSpecification) |
There was a problem hiding this comment.
Nit: The HashSpecification class is not the same as the HashSpecification property of AwsSigningAttributes so reusing the same symbol is incorrect. For properties, we should just use the literal name in the codegen text:
writer.write(
"op.context[#T.HashSpecification] = #T.Precalculated(it)",
RuntimeTypes.Auth.Signing.AwsSigningCommon.AwsSigningAttributes,
RuntimeTypes.Auth.Signing.AwsSigningCommon.HashSpecification,
)
|
addressed the issue with #1224 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service has a header binding for
x-amz-content-sha256, use that input members' value for theHashSpecificationif it's set. This addresses the issue reported in #1217.Issue #
Closes #1217
Description of changes
This change is required because the Codeartifact services has an HTTP header binding for
x-amz-content-sha256, which conflicts with theaws-chunkedcontent encoding specification.If a user sets the member associated with the header binding, use that value instead of computing it with
aws-chunked.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.