-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 Customization to handle status code 200 Errors #199
Comments
There are a few approaches here. We probably will already have a custom error middleware for S3 for handling custom metadata. This logic could be added to the existing middleware. Alternatively, a middleware could be mapped to only specific operations as the Go SDK does. This would be more work as I don't believe we have support for that at this time. estimate (group in w/ existing S3 error handler): 1 week |
|
Apparently DeleteObjects can also return a 200 error response: awslabs/aws-sdk-rust#873 Likely any control plane API is able to return a 200 error response. |
|
Related to smithy-lang/smithy-kotlin#323
Relevant information from @aajtodd copied from related ticket:
Here is what Go does for status code 200 Errors:
https://github.com/aws/aws-sdk-go-v2/blob/main/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3ErrorWith200Status.java#L18
https://github.com/aws/aws-sdk-go-v2/blob/d05dd9b08d180c3696c33130548881966b56ea29/service/s3/internal/customizations/handle_200_error.go#L33
Once 200 errors are properly parsed, ensure that standard retry logic properly retries on
InternalError
as noted in the comment below.The text was updated successfully, but these errors were encountered: