Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Customization to handle status code 200 Errors #199

Closed
kggilmer opened this issue May 21, 2021 · 4 comments · Fixed by #1117
Closed

S3 Customization to handle status code 200 Errors #199

kggilmer opened this issue May 21, 2021 · 4 comments · Fixed by #1117
Assignees
Labels
no-auto-closure We do not want this issue to be automatically closed.

Comments

@kggilmer
Copy link
Contributor

kggilmer commented May 21, 2021

Related to smithy-lang/smithy-kotlin#323

Relevant information from @aajtodd copied from related ticket:

Here is what Go does for status code 200 Errors:

https://github.com/aws/aws-sdk-go-v2/blob/main/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3ErrorWith200Status.java#L18
https://github.com/aws/aws-sdk-go-v2/blob/d05dd9b08d180c3696c33130548881966b56ea29/service/s3/internal/customizations/handle_200_error.go#L33

Once 200 errors are properly parsed, ensure that standard retry logic properly retries on InternalError as noted in the comment below.

@kggilmer
Copy link
Contributor Author

There are a few approaches here. We probably will already have a custom error middleware for S3 for handling custom metadata. This logic could be added to the existing middleware. Alternatively, a middleware could be mapped to only specific operations as the Go SDK does. This would be more work as I don't believe we have support for that at this time.

estimate (group in w/ existing S3 error handler): 1 week
estimate (provide middleware per-operation): 3 weeks

@aajtodd aajtodd transferred this issue from smithy-lang/smithy-kotlin Jul 8, 2021
@aajtodd aajtodd added this to the M4 milestone Aug 2, 2021
@aajtodd aajtodd modified the milestones: M4, M6 Sep 27, 2021
@aajtodd
Copy link
Contributor

aajtodd commented Jan 18, 2022

new_retries SEP recently added
200 | InternalError | s3

@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Jul 11, 2022
@aajtodd
Copy link
Contributor

aajtodd commented Aug 29, 2023

Apparently DeleteObjects can also return a 200 error response: awslabs/aws-sdk-rust#873

Likely any control plane API is able to return a 200 error response.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants