feat: handle S3 error responses with HTTP 200 status code #1117
Conversation
|
A new generated diff is ready to view. |
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertFailsWith | ||
|
|
||
| class Handle200ErrorsInterceptorTest { |
There was a problem hiding this comment.
You could also add a test ensuring error payloads are unmodified (tests L27 of your interceptor if (!response.status.isSuccess()) return response)
| assertEquals(expectedMessage, ex.sdkErrorMetadata.errorMessage) | ||
| assertEquals(expectedMessage, ex.sdkErrorMetadata.errorMessage) |
There was a problem hiding this comment.
Nit:
Double line.
Double line.
| override fun enabledForService(model: Model, settings: KotlinSettings): Boolean = | ||
| model.expectShape<ServiceShape>(settings.service).isS3 |
There was a problem hiding this comment.
Question: Should this apply to any other S3-adjacent services like S3 Control, Glacier, etc.?
There was a problem hiding this comment.
This is a good question, I actually think several of our customizations may need to apply to both s3 and s3 control. Not 100% on which ones though.
aajtodd
force-pushed
the
s3-200-errors
branch
from
cd63dff to
d0723dc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view. |
Issue #
fixes #199
Description of changes
Adds an interceptor that attempts to parse the response XML as an error response and resets the HTTP status code accordingly to trigger error handling.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.