feat(rt): retry certain HTTP errors (SRA) #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
lauzadis
approved these changes
Apr 12, 2023
ianbotsf
requested changes
Apr 17, 2023
| "IDPCommunicationError" to Timeout, | ||
| "IDPCommunicationError" to Transient, |
There was a problem hiding this comment.
Comment: It looks like the specification has been updated since our original implementation and now the "InternalError" error code must also be treated as a Transient error.
There was a problem hiding this comment.
Discussed offline. We are going to punt on this for now since it's covered by #199
aajtodd
force-pushed
the
feat-http-exceptions
branch
from
2648764 to
2b9cd15
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lauzadis
approved these changes
Apr 19, 2023
ianbotsf
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
upstream: smithy-lang/smithy-kotlin#829
Description of changes
Track upstream HTTP exception changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.