Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc update docker tag command to use existing variable #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doc update docker tag command to use existing variable #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ You may want to activate the Python environment in your `.bashrc` or `.zshrc`.
-- [AmazonS3FullAccess](https://console.aws.amazon.com/iam/home#policies/arn:aws:iam::aws:policy/AmazonS3FullAccess) <br>
-- [AmazonEC2ContainerRegistryFullAccess](https://console.aws.amazon.com/iam/home#policies/arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryFullAccess) <br>

5. [Create](https://docs.aws.amazon.com/cli/latest/reference/ecr/create-repository.html) an ECR repository with the name "sagemaker-spark" in the us-west-2 region
5. [Create](https://docs.aws.amazon.com/cli/latest/reference/ecr/create-repository.html) an ECR repository with the name `sagemaker-spark` in the `us-west-2` region
```
aws ecr create-repository --repository-name sagemaker-spark --region us-west-2
```

6. Setup required environment variables for the container build:
```
Expand Down Expand Up @@ -107,17 +110,17 @@ To run tests against Amazon SageMaker using your newly built container image, fi

1. Bootstrap docker credentials for your repository
```
aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin $AWS_ACCOUNT_ID.dkr.ecr.us-west-2.amazonaws.com
aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com
```

2. Tag the latest Spark image
```
docker tag $SPARK_REPOSITORY_NAME:latest $AWS_ACCOUNT_ID.dkr.ecr.us-west-2.amazonaws.com/$SPARK_REPOSITORY:$VERSION
docker tag ${SPARK_REPOSITORY}:${VERSION} ${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/${SPARK_REPOSITORY}:${VERSION}
```

3. Push the latest Spark image to your ECR repository
```
docker push $AWS_ACCOUNT_ID.dkr.ecr.us-west-2.amazonaws.com/$SPARK_REPOSITORY:$VERSION
docker push ${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/${SPARK_REPOSITORY}:${VERSION}
```

5. Run the SageMaker tests
Expand Down