Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc update docker tag command to use existing variable #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavel-balas
Copy link

Issue #, if available:

The command in the documentation refers to the SPARK_REPOSITORY_NAME environment variable which doesn't exists. The documentation mention only SPARK_REPOSITORY variable.

Description of changes:

Use SPARK_REPOSITORY in the docker tag command tag.

I'm also doing two more small changes

  • adding exact command aws ecr create-repository where only link to the aws official doc is mentioned.
  • wrapping environment variables into brackets (e.g. ${VARIABLE}). The colon (:) character may mean formatting for variable so wrapping brackets are safer
% echo $SPARK_REPOSITORY:latest  
sagemaker-sparkatest

% echo ${SPARK_REPOSITORY}:latest
sagemaker-spark:latest

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pavel-balas pavel-balas changed the title Update docker tag command to use existing variable doc update docker tag command to use existing variable Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant