Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module py back and ignore the vulnerability 51457 #109

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Add module py back and ignore the vulnerability 51457 #109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b952a0
Remove py as dependency which cause security vulnerability check fail
can-sun Mar 23, 2023
17ae6a7
Add module py back and ignore the vulnerability 51457
can-sun Mar 27, 2023
79d692d
Add some comments
can-sun Mar 27, 2023
eb3f196
Add comments
can-sun Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ build-container-library: init

install-container-library: init
# temporarily bypass urllib3 because circular dependency will be introduced if bumped up urllib3 version
pipenv run safety check -i 43975 # https://github.com/pyupio/safety
# temporarily bypass py=1.1.0 because pytest-parallel has a dependency on it however the module is no longer maitained.
# In the future the pylib will be removed from pytest-parallel dependency and 51457 should only impact the local tests.
# For more info, https://github.com/pytest-dev/py/issues/287
pipenv run safety check -i 43975 -i 51457 # https://github.com/pyupio/safety
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore is recommended by the author. So temp to approve this to unblock Can's MCM.


build-static-config:
./scripts/fetch-ec2-instance-type-info.sh --region ${REGION} --use-case ${USE_CASE} --spark-version ${SPARK_VERSION} \
Expand Down