Add module py back and ignore the vulnerability 51457 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxshe
reviewed
Mar 27, 2023
| # temporarily bypass py=1.1.0 because pytest-parallel has a dependency on it however the module is no longer maitained. | ||
| # In the future the pylib will be removed from pytest-parallel dependency and 51457 should only impact the local tests. | ||
| # For more info, https://github.com/pytest-dev/py/issues/287 | ||
| pipenv run safety check -i 43975 -i 51457 # https://github.com/pyupio/safety |
There was a problem hiding this comment.
The ignore is recommended by the author. So temp to approve this to unblock Can's MCM.
xiaoxshe
approved these changes
Mar 27, 2023
mahendruajay
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Verified that pytest-parallel has a dependency on pylib and for some reason, pytest-parallel is not installing it correctly.
Issue can be found here kevlened/pytest-parallel#118
The work-around is adding the pylib manually in Pipfile however 1.11.0 (latest) fails the vulnerability check which should be ignored recommended by the author of the module.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.