Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type-safe-api): revert add compilation to ESM for TypeScript #575

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix(type-safe-api): revert add compilation to ESM for TypeScript #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions packages/type-safe-api/src/project/codegen/runtime/generated-typescript-runtime-project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*! Copyright [Amazon.com](http://amazon.com/), Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0 */
import { NodePackageUtils } from "@aws/monorepo";
import { IgnoreFile, JsonFile } from "projen";
import { IgnoreFile } from "projen";
import { NodePackageManager } from "projen/lib/javascript";
import { TypeScriptProject } from "projen/lib/typescript";
import { Language } from "../../languages";
Expand Down Expand Up @@ -121,22 +121,6 @@ export class GeneratedTypescriptRuntimeProject extends TypeScriptProject {

this.preCompileTask.spawn(generateTask);

// Add compilation to ESM as well
const compileESMTask = this.addTask("compile-esm");
compileESMTask.exec("tsc -p tsconfig.esm.json");
new JsonFile(this, "tsconfig.esm.json", {
obj: {
extends: "./tsconfig.dev.json",
compilerOptions: {
module: "esnext",
moduleResolution: "nodenext",
outDir: "lib/esm",
},
},
});

this.compileTask.spawn(compileESMTask);

// Ignore all the generated code
this.gitignore.addPatterns(
"src",
Expand Down
Loading