fix(type-safe-api): revert add compilation to ESM for TypeScript #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 0a6323a.
cogwirrel
changed the title
agdimech
approved these changes
Sep 13, 2023
|
Ha, classic CJS vs ESM! Well I do love the path of least resistance :P, so all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #561
Unfortunately, it seems as though this combination of
moduleandmoduleResolutionno longer works as of TypeScript 5.2.With TS 5.2, we get the error:
See: https://www.totaltypescript.com/concepts/option-module-must-be-set-to-nodenext-when-option-moduleresolution-is-set-to-nodenext#solution-2
It seems as though with TS 5.2 it's tricky to build hybrid esm/cjs packages: microsoft/TypeScript#55705
So unfortunately reverting this as the path of least resistance for now. Sorry @zetashift ! :(