Add support for .NET 8 deployments #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // ProjectDefinitionParser will have transformed projectDirectory to an absolute path, | ||
| // and DockerFileName is static so traversal should not be possible here. | ||
| // nosemgrep: csharp.lang.security.filesystem.unsafe-path-combine.unsafe-path-combine | ||
| File.WriteAllText(Path.Combine(projectDirectory, DockerFileName), dockerFile); | ||
| File.WriteAllText(Path.Combine(projectDirectory, Constants.Docker.DefaultDockerfileName), dockerFile); |
Check warning
Code scanning / Semgrep
String argument projectDirectory is used to read or write data from a file via Path.Combine without direct sanitization via Path.GetFileName. If the path is user-supplied data this can lead to path traversal. Warning
ashovlin
approved these changes
Oct 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #793 +/- ##
==========================================
+ Coverage 61.27% 61.46% +0.19%
==========================================
Files 276 277 +1
Lines 10554 10659 +105
Branches 1463 1484 +21
==========================================
+ Hits 6467 6552 +85
- Misses 3547 3566 +19
- Partials 540 541 +1
☔ View full report in Codecov by Sentry. |
96malhar
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-7160
DOTNET-7159
DOTNET-7201
Description of changes:
Release of the feature branch which includes approved PRs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.