Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image uploader console app to work with latest changes #797

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

philasmar
Copy link
Contributor

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar force-pushed the asmarp/fix-image-uploader branch from b79b295 to 800125f Compare October 17, 2023 17:04
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. For my understanding, does the recommendation matter (and we're relying on whatever happens to be first today)? Or is any fine?

@philasmar
Copy link
Contributor Author

Code looks fine. For my understanding, does the recommendation matter (and we're relying on whatever happens to be first today)? Or is any fine?

Recommendation doesn't matter. It is now required to be passed to the GenerateDockerfile function just so we can check the target framework. So any would be fine.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (c060951) 61.27% compared to head (800125f) 61.46%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #797      +/-   ##
==========================================
+ Coverage   61.27%   61.46%   +0.19%     
==========================================
  Files         276      277       +1     
  Lines       10554    10659     +105     
  Branches     1463     1484      +21     
==========================================
+ Hits         6467     6552      +85     
- Misses       3547     3566      +19     
- Partials      540      541       +1     
Files Coverage Δ
...y.CLI/Commands/TypeHints/TypeHintCommandFactory.cs 95.12% <100.00%> (+0.12%) ⬆️
...eploy.Common/DeploymentBundles/DeploymentBundle.cs 100.00% <100.00%> (ø)
src/AWS.Deploy.Common/Exceptions.cs 63.41% <ø> (ø)
src/AWS.Deploy.Constants/Docker.cs 100.00% <100.00%> (ø)
src/AWS.Deploy.DockerEngine/DockerEngine.cs 84.33% <100.00%> (+3.45%) ⬆️
src/AWS.Deploy.DockerEngine/DockerFile.cs 89.28% <100.00%> (+6.93%) ⬆️
...c/AWS.Deploy.Orchestration/OptionSettingHandler.cs 77.94% <100.00%> (+0.22%) ⬆️
src/AWS.Deploy.Orchestration/Exceptions.cs 5.88% <0.00%> (-0.18%) ⬇️
...igFileDeployment/DeploymentSettingsHandlerTests.cs 0.00% <0.00%> (ø)
src/AWS.Deploy.Orchestration/Orchestrator.cs 65.50% <75.00%> (+3.06%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philasmar philasmar merged commit 3bfe0de into dev Oct 17, 2023
10 checks passed
@philasmar philasmar deleted the asmarp/fix-image-uploader branch October 17, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants