feat: add support for .NET8 container-based web apps #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // ProjectDefinitionParser will have transformed projectDirectory to an absolute path, | ||
| // and DockerFileName is static so traversal should not be possible here. | ||
| // nosemgrep: csharp.lang.security.filesystem.unsafe-path-combine.unsafe-path-combine | ||
| File.WriteAllText(Path.Combine(projectDirectory, DockerFileName), dockerFile); | ||
| File.WriteAllText(Path.Combine(projectDirectory, Constants.Docker.DefaultDockerfileName), dockerFile); |
Check warning
Code scanning / Semgrep
String argument projectDirectory is used to read or write data from a file via Path.Combine without direct sanitization via Path.GetFileName. If the path is user-supplied data this can lead to path traversal. Warning
normj
requested changes
Oct 10, 2023
philasmar
force-pushed
the
asmarp/net8-containers
branch
3 times, most recently
from
d946e35 to
c418ac6
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/net8 #792 +/- ##
===============================================
Coverage ? 61.46%
===============================================
Files ? 277
Lines ? 10659
Branches ? 1484
===============================================
Hits ? 6552
Misses ? 3566
Partials ? 541 ☔ View full report in Codecov by Sentry. |
normj
requested changes
Oct 11, 2023
ashovlin
reviewed
Oct 11, 2023
philasmar
force-pushed
the
asmarp/net8-containers
branch
2 times, most recently
from
61a32e6 to
abbbae4
Compare
philasmar
force-pushed
the
asmarp/net8-containers
branch
from
abbbae4 to
95618f9
Compare
normj
approved these changes
Oct 13, 2023
ashovlin
approved these changes
Oct 13, 2023
philasmar
force-pushed
the
asmarp/net8-containers
branch
from
95618f9 to
70d08b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-7201
Description of changes:
docker inspectto access the environment variables in the container after we build it.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.