Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for NodeJS 18 in generated dockerfiles #787

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat: add support for NodeJS 18 in generated dockerfiles #787

merged 1 commit into from
Sep 21, 2023

Conversation

philasmar
Copy link
Contributor

Description of changes:

  • Upgrade NodeJS to v18 since v16 reached it's end of life and deployments were showing a deprecation notice.
  • Upgraded project dependencies
  • Adapted project to allow building it with .NET8 SDK
  • Updated the way we were installing NodeJS on our dockerfiles since the script we were using has also been deprecated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar force-pushed the asmarp/upgrade-to-node18 branch from 74dfa0c to bee8fd9 Compare September 20, 2023 17:51
@philasmar philasmar requested a review from normj September 20, 2023 17:52
@philasmar philasmar force-pushed the asmarp/upgrade-to-node18 branch from bee8fd9 to b667a50 Compare September 20, 2023 20:09
@philasmar philasmar requested a review from ashovlin September 20, 2023 20:11
@philasmar philasmar force-pushed the asmarp/upgrade-to-node18 branch from b667a50 to 8e839e3 Compare September 21, 2023 13:30
@philasmar philasmar changed the title chore: upgrade NodeJS to v18 feat: add support for NodeJS 18 in generated dockerfiles Sep 21, 2023
ashovlin
ashovlin approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after https://github.com/aws/aws-dotnet-deploy/compare/b667a50dc3b63566ef412e6aecc81637ad5d520f..8e839e30eb2a203b08f212be2a11baa49fc48426

@codecov
Copy link

codecov bot commented Sep 21, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@philasmar philasmar merged commit 2b85dfd into dev Sep 21, 2023
@philasmar philasmar deleted the asmarp/upgrade-to-node18 branch September 21, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normj normj normj approved these changes

@ashovlin ashovlin ashovlin approved these changes

@96malhar 96malhar Awaiting requested review from 96malhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philasmar @ashovlin @normj