Skip to content

Commit

Permalink
chore: upgrade NodeJS to v18
Browse files Browse the repository at this point in the history
  • Loading branch information
philasmar committed Sep 20, 2023
1 parent b47133c commit 74dfa0c
Show file tree
Hide file tree
Showing 55 changed files with 217 additions and 264 deletions.
12 changes: 3 additions & 9 deletions AWS.Deploy.sln
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Microsoft Visual Studio Solution File, Format Version 12.00

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.0.32126.317
MinimumVisualStudioVersion = 10.0.40219.1
Expand Down Expand Up @@ -36,12 +37,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.DockerEngine", "
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.Common", "src\AWS.Deploy.Common\AWS.Deploy.Common.csproj", "{3AAC19A6-02E8-45D0-BDD0-CAD0FBE15F64}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ManualLinuxTesting", "ManualLinuxTesting", "{D0172E70-D5BC-4EDE-84E4-9ADB67B5F8FB}"
ProjectSection(SolutionItems) = preProject
test\ManualLinuxTesting\Dockerfile = test\ManualLinuxTesting\Dockerfile
test\ManualLinuxTesting\Readme.md = test\ManualLinuxTesting\Readme.md
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.Recipes.CDK.Common", "src\AWS.Deploy.Recipes.CDK.Common\AWS.Deploy.Recipes.CDK.Common.csproj", "{FAE4D4C5-9107-4622-A050-E30CC70BE754}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.Orchestration.UnitTests", "test\AWS.Deploy.Orchestration.UnitTests\AWS.Deploy.Orchestration.UnitTests.csproj", "{3F7A5CA6-7178-4DBF-8DAD-6A63684C7A8E}"
Expand Down Expand Up @@ -70,7 +65,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BlazorWasm60", "testapps\Bl
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.DocGenerator", "src\AWS.Deploy.DocGenerator\AWS.Deploy.DocGenerator.csproj", "{6D4BD0C2-C2A0-4AFB-BC22-623DD64A4F84}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "AWS.Deploy.DocGenerator.UnitTests", "test\AWS.Deploy.DocGenerator.UnitTests\AWS.Deploy.DocGenerator.UnitTests.csproj", "{7E661545-7DFD-4FE3-A5F9-767FAE30DFFE}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AWS.Deploy.DocGenerator.UnitTests", "test\AWS.Deploy.DocGenerator.UnitTests\AWS.Deploy.DocGenerator.UnitTests.csproj", "{7E661545-7DFD-4FE3-A5F9-767FAE30DFFE}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down Expand Up @@ -194,7 +189,6 @@ Global
{F06F9F2B-9018-4357-9ECB-EAF3D9EC335C} = {11C7056E-93C1-408B-BD87-5270595BBE0E}
{4C4F07CE-4C88-44C6-864F-C5E563712EE2} = {11C7056E-93C1-408B-BD87-5270595BBE0E}
{3AAC19A6-02E8-45D0-BDD0-CAD0FBE15F64} = {11C7056E-93C1-408B-BD87-5270595BBE0E}
{D0172E70-D5BC-4EDE-84E4-9ADB67B5F8FB} = {BD466B5C-D8B0-4069-98A9-6DC8F01FA757}
{FAE4D4C5-9107-4622-A050-E30CC70BE754} = {11C7056E-93C1-408B-BD87-5270595BBE0E}
{3F7A5CA6-7178-4DBF-8DAD-6A63684C7A8E} = {BD466B5C-D8B0-4069-98A9-6DC8F01FA757}
{4AD9D400-3F3D-4076-B34C-0F88576C1889} = {BD466B5C-D8B0-4069-98A9-6DC8F01FA757}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ To take advantage of this library you’ll need:
* Note: You need to make sure to add the appropriate CloudFormation permissions to your credentials's profile / assumed role.
* For SSO, please visit the [.NET SDK Reference Guide](https://docs.aws.amazon.com/sdkref/latest/guide/access-sso.html).
* [.NET 6](https://dotnet.microsoft.com/download) or later
* [Node.js 14](https://nodejs.org/en/download/) or later
* [Node.js 18](https://nodejs.org/en/download/) or later
* The [AWS Cloud Development Kit (CDK)](https://aws.amazon.com/cdk/) is used by this tool to create the AWS infrastructure to run applications. The CDK requires Node.js to function. This dependency is needed for deployments that are CDK based. If you will be using deployments that are not CDK based, you are not required to have this dependency.
* (optional) [Docker](https://docs.docker.com/get-docker/)
* Used when deploying to a container based service like Amazon Elastic Container Service (Amazon ECS)
Expand Down
2 changes: 1 addition & 1 deletion buildtools/ci.buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 0.2
phases:
install:
runtime-versions:
nodejs: 16
nodejs: 18
commands:
# install .NET SDK
- curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --channel 6.0
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/getting-started/pre-requisites.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dotnet --version

#### Node.js

* The deployment tool requires the [AWS Cloud Development Kit (CDK)](https://docs.aws.amazon.com/cdk/latest/guide/), and the AWS CDK requires [Node.js](https://nodejs.org/en/download/). AWS CDK requires Node.js, versions 14.x, 16.x, 18.x (or later) - we recommend installing the latest LTS version.
* The deployment tool requires the [AWS Cloud Development Kit (CDK)](https://docs.aws.amazon.com/cdk/latest/guide/), and the AWS CDK requires [Node.js](https://nodejs.org/en/download/). AWS CDK requires Node.js 18.x (or later) - we recommend installing the latest LTS version.

* To install Node.js, go to [Node.js downloads](https://nodejs.org/en/download/)

Expand Down
2 changes: 1 addition & 1 deletion site/content/troubleshooting-guide/missing-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This section of the troubleshooting guide explains how to determine, diagnose, a

**Why is this happening**: AWS.Deploy.Tools relies on [AWS Cloud Development Kit](https://aws.amazon.com/cdk/) (CDK) to provision resources for your cloud application. AWS CDK requires Node.js to be installed in your machine. See the [CDK's FAQs](https://aws.amazon.com/cdk/faqs/) for more information about how it uses Node.js.

*Minimum required Node.js version >= 14.17.0*
*Minimum required Node.js version >= 18.x*

**Resolution**: See [here](https://nodejs.org/en/download/) to install Node.js on your system.

Expand Down
20 changes: 12 additions & 8 deletions src/AWS.Deploy.CLI/AWS.Deploy.CLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.100.15" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.101.9" />
<PackageReference Include="AWSSDK.SecurityToken" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.SSO" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.SSOOIDC" Version="3.7.100.14" />
<PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="6.1.2" />
<PackageReference Include="Swashbuckle.AspNetCore.Swagger" Version="6.1.2" />
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.203.36" />
<PackageReference Include="AWSSDK.SecurityToken" Version="3.7.201.38" />
<PackageReference Include="AWSSDK.SSO" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.SSOOIDC" Version="3.7.200.42" />
<PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="6.5.0" />
<PackageReference Include="Swashbuckle.AspNetCore.Swagger" Version="6.5.0" />
<PackageReference Include="System.CommandLine" Version="2.0.0-beta1.20574.7" />
<PackageReference Include="System.Text.Json" Version="6.0.4" />
<PackageReference Include="System.Text.Json" Version="6.0.8" />
</ItemGroup>

<ItemGroup>
Expand All @@ -47,6 +47,10 @@
<None Include="..\..\README.md" Pack="true" PackagePath="" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Nerdbank.GitVersioning" Version="3.6.133" />
</ItemGroup>

<Import Project="..\AWS.Deploy.Constants\AWS.Deploy.Constants.projitems" Label="Shared" />

</Project>
4 changes: 2 additions & 2 deletions src/AWS.Deploy.CLI/Commands/DeployCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ private async Task CreateDeploymentBundle(Orchestrator orchestrator, Recommendat
{
if (_toolInteractiveService.DisableInteractive)
{
throw ex;
throw;
}

_toolInteractiveService.WriteLine("Docker builds usually fail due to executing them from a working directory that is incompatible with the Dockerfile." +
Expand Down Expand Up @@ -615,7 +615,7 @@ private async Task CreateDeploymentBundle(Orchestrator orchestrator, Recommendat
}
else
{
throw ex;
throw;
}
}
}
Expand Down
40 changes: 20 additions & 20 deletions src/AWS.Deploy.Common/AWS.Deploy.Common.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
Expand All @@ -8,25 +8,25 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AWSSDK.CloudControlApi" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.CloudWatchEvents" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.EC2" Version="3.7.105.3" />
<PackageReference Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.2" />
<PackageReference Include="AWSSDK.SecurityToken" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.AppRunner" Version="3.7.102.7" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.101.9" />
<PackageReference Include="AWSSDK.CloudFront" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ECR" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ECS" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.100.15" />
<PackageReference Include="AWSSDK.S3" Version="3.7.101.14" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.101.4" />
<PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.SQS" Version="3.7.100.14" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ElasticLoadBalancingV2" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.CloudControlApi" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.CloudWatchEvents" Version="3.7.201.12" />
<PackageReference Include="AWSSDK.EC2" Version="3.7.214" />
<PackageReference Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.7" />
<PackageReference Include="AWSSDK.SecurityToken" Version="3.7.201.38" />
<PackageReference Include="AWSSDK.AppRunner" Version="3.7.201.14" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.203.36" />
<PackageReference Include="AWSSDK.CloudFront" Version="3.7.201.36" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.201.13" />
<PackageReference Include="AWSSDK.ECR" Version="3.7.201.6" />
<PackageReference Include="AWSSDK.ECS" Version="3.7.201.12" />
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.S3" Version="3.7.203.17" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.SQS" Version="3.7.200.43" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.ElasticLoadBalancingV2" Version="3.7.201.27" />
</ItemGroup>

<Import Project="..\AWS.Deploy.Constants\AWS.Deploy.Constants.projitems" Label="Shared" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public async Task<ValidationResult> Validate(object input, Recommendation recomm
}
else // Anything else is unexpected, so proceed with usual exception handling
{
throw ex;
throw;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/AWS.Deploy.DockerEngine/AWS.Deploy.DockerEngine.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
Expand All @@ -21,7 +21,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="System.Text.Json" Version="4.7.2" />
<PackageReference Include="System.Text.Json" Version="6.0.8" />
</ItemGroup>

</Project>
7 changes: 5 additions & 2 deletions src/AWS.Deploy.DockerEngine/Templates/Dockerfile.template
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ RUN dotnet build "{project-name}" -c Release -o /app/build

FROM build AS publish
RUN apt-get update -yq \
&& apt-get install curl gnupg -yq \
&& curl -sL https://deb.nodesource.com/setup_14.x | bash \
&& apt-get install -yq ca-certificates curl gnupg \
&& mkdir -p /etc/apt/keyrings \
&& curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
&& echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list \
&& apt-get update -yq \
&& apt-get install nodejs -yq
RUN dotnet publish "{project-name}" -c Release -o /app/publish

Expand Down
42 changes: 21 additions & 21 deletions src/AWS.Deploy.Orchestration/AWS.Deploy.Orchestration.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
Expand All @@ -12,28 +12,28 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AWSSDK.CloudControlApi" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.SQS" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.CloudWatchEvents" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.CloudFront" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.EC2" Version="3.7.105.3" />
<PackageReference Include="AWSSDK.ECR" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ECS" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ElasticLoadBalancingV2" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.100.15" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.101.9" />
<PackageReference Include="AWSSDK.S3" Version="3.7.101.14" />
<PackageReference Include="AWSSDK.AppRunner" Version="3.7.102.7" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.101.4" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="5.0.0" />
<PackageReference Include="AWSSDK.CloudControlApi" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.201.13" />
<PackageReference Include="AWSSDK.SQS" Version="3.7.200.43" />
<PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.CloudWatchEvents" Version="3.7.201.12" />
<PackageReference Include="AWSSDK.CloudFront" Version="3.7.201.36" />
<PackageReference Include="AWSSDK.EC2" Version="3.7.214" />
<PackageReference Include="AWSSDK.ECR" Version="3.7.201.6" />
<PackageReference Include="AWSSDK.ECS" Version="3.7.201.12" />
<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.ElasticLoadBalancingV2" Version="3.7.201.27" />
<PackageReference Include="AWSSDK.IdentityManagement" Version="3.7.200.42" />
<PackageReference Include="AWSSDK.CloudFormation" Version="3.7.203.36" />
<PackageReference Include="AWSSDK.S3" Version="3.7.203.17" />
<PackageReference Include="AWSSDK.AppRunner" Version="3.7.201.14" />
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.200.42" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageReference Include="Microsoft.TemplateEngine.IDE" Version="5.0.1" />
<PackageReference Include="Microsoft.TemplateEngine.Orchestrator.RunnableProjects" Version="5.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="System.Linq.Async" Version="4.0.0" />
<PackageReference Include="YamlDotNet" Version="9.1.4" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
<PackageReference Include="YamlDotNet" Version="13.4.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Orchestration/Data/AWSResourceQueryer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ public async Task<Vpc> GetDefaultVpc()
}
}
})
.Vpcs.FirstOrDefaultAsync(),
.Vpcs.FirstAsync(),
"Error attempting to retrieve the default VPC");
}

Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Orchestration/SystemCapabilityEvaluator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class SystemCapabilityEvaluator : ISystemCapabilityEvaluator
private const string DOCKER_INSTALLATION_URL = "https://docs.docker.com/engine/install/";

private readonly ICommandLineWrapper _commandLineWrapper;
private static readonly Version MinimumNodeJSVersion = new Version(14,17,0);
private static readonly Version MinimumNodeJSVersion = new Version(18,0,0);

public SystemCapabilityEvaluator(ICommandLineWrapper commandLineWrapper)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.96.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.96.2" />

<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ namespace AspNetAppAppRunner
{
sealed class Program
{
public static void Main(string[] args)
public static void Main()
{
var app = new App();

var builder = new ConfigurationBuilder().AddAWSDeployToolConfiguration(app);
var recipeProps = builder.Build().Get<RecipeProps<Configuration>>();
if (recipeProps is null)
{
throw new InvalidOrMissingConfigurationException("The configuration is missing for the selected recipe.");
}
var appStackProps = new DeployToolStackProps<Configuration>(recipeProps)
{
Env = new Environment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.96.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ namespace AspNetAppEcsFargate
{
sealed class Program
{
public static void Main(string[] args)
public static void Main()
{
var app = new App();

var builder = new ConfigurationBuilder().AddAWSDeployToolConfiguration(app);
var recipeProps = builder.Build().Get<RecipeProps<Configuration>>();
if (recipeProps is null)
{
throw new InvalidOrMissingConfigurationException("The configuration is missing for the selected recipe.");
}
var appStackProps = new DeployToolStackProps<Configuration>(recipeProps)
{
Env = new Environment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@

<ItemGroup>
<!-- CDK Construct Library dependencies -->
<PackageReference Include="Amazon.CDK.Lib" Version="2.43.1" />
<PackageReference Include="Amazon.CDK.Lib" Version="2.96.2" />

<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.100.14" />
<PackageReference Include="AWSSDK.ElasticBeanstalk" Version="3.7.200.42" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

<!-- jsii Roslyn analyzers (un-comment to obtain compile-time checks for missing required props
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ private string ConfigureApplication(Configuration settings)
ApplicationName = beanstalkApplicationName
}));

ApplicationVersion.AddDependsOn(BeanstalkApplication);
ApplicationVersion.AddDependency(BeanstalkApplication);
}

return beanstalkApplicationName;
Expand Down
Loading

0 comments on commit 74dfa0c

Please sign in to comment.