Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tweaking notification workflows #3269

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Oct 3, 2023

Description

Updating the notifications workflows to:

  • Filter by author_association instead of hardcoding aliases, for both comments and issues
  • Notify the comment author instead of the issue author
  • Remove notifications for draft releases, they are just spammy

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner October 3, 2023 15:11
Copy link
Member

@atierian atierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be including "CONTRIBUTOR"? According to the docs:

CONTRIBUTOR
Author has previously committed to the repository

It sounds like that would include non-maintainers that have made a contribution.

I think "MEMBER" by itself fulfills our needs here, right?

MEMBER
Author is a member of the organization that owns the repository.

@ruisebas ruisebas temporarily deployed to Fortify October 3, 2023 15:26 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #3269 (1da7f6d) into main (fc9fe26) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
- Coverage   64.77%   64.65%   -0.13%     
==========================================
  Files        1094     1094              
  Lines       37260    37260              
==========================================
- Hits        24135    24090      -45     
- Misses      13125    13170      +45     
Flag Coverage Δ
API_plugin_unit_test 67.10% <ø> (ø)
AWSPluginsCore 65.86% <ø> (ø)
Amplify 47.84% <ø> (ø)
Analytics_plugin_unit_test 86.39% <ø> (ø)
Auth_plugin_unit_test 75.03% <ø> (-0.06%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.07% <ø> (-0.60%) ⬇️
Geo_plugin_unit_test 84.28% <ø> (ø)
Logging_plugin_unit_test 63.41% <ø> (ø)
Predictions_plugin_unit_test 34.87% <ø> (ø)
PushNotifications_plugin_unit_test 69.69% <ø> (ø)
Storage_plugin_unit_test 54.07% <ø> (ø)
unit_tests 64.65% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruisebas ruisebas merged commit 49a248b into main Oct 3, 2023
76 checks passed
@ruisebas ruisebas deleted the ruisebas/fixing_workflows branch October 3, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants