Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improving notifications workflows [skip ci] #4985

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chore: improving notifications workflows [skip ci] #4985

merged 2 commits into from
Oct 4, 2023

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Oct 3, 2023 •
edited
Loading

Description of changes:

Same as aws-amplify/amplify-swift#3269 and aws-amplify/amplify-swift#3273, updating the notifications workflows to:

  • Filter by author_association instead of hardcoding aliases, for both comments and issues
  • Notify the comment author instead of the issue author
  • Remove notifications for draft releases, they are just spammy
  • Sends the name of the repo instead of the URL when notifying releases.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners October 3, 2023 19:41
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 3, 2023 19:41 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest October 4, 2023 15:48 — with GitHub Actions Inactive
@sebaland sebaland merged commit a2bf4fa into main Oct 4, 2023
@sebaland sebaland deleted the ruisebas/fixing_workflows branch October 4, 2023 16:08
harsh62 pushed a commit that referenced this pull request Nov 16, 2023
@sebaland @harsh62
chore: improving notifications workflows [skip ci] (#4985)
8098317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebaland @harsh62