Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header #42

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

JWhitleyWork
Copy link
Collaborator

Not having this header has been causing build failures in rolling and won't hurt any earlier releases.

Signed-off-by: Joshua Whitley <[email protected]>
@xmfcx xmfcx force-pushed the fix/missing_header branch from 5f2a7a7 to f7af127 Compare March 26, 2024 14:00
@xmfcx
Copy link
Contributor

xmfcx commented Mar 26, 2024

Rebased to test with the latest CI.

@xmfcx xmfcx self-requested a review March 26, 2024 14:00
@xmfcx
Copy link
Contributor

xmfcx commented Mar 26, 2024

It still fails at the test for rolling but it at least builds now.

Thanks @JWhitleyWork (I've also given you the write permissions for this repository since you have too much history in this package)

@xmfcx xmfcx merged commit d25a555 into autowarefoundation:main Mar 26, 2024
4 of 6 checks passed
@JWhitleyWork JWhitleyWork deleted the fix/missing_header branch March 26, 2024 17:53
@JWhitleyWork
Copy link
Collaborator Author

Thanks, @xmfcx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants