New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use find_package to fix rolling build error #43

Closed

xmfcx wants to merge 1 commit into main from fix/rolling-build-error

Contributor

xmfcx commented Mar 26, 2024

Follow up from:

Add missing header #42

Attempts to fix:

https://github.com/autowarefoundation/ros2_socketcan/actions/runs/8421904097/job/23059902100?pr=42#step:5:371

I don't know why is this necessary but without find_package(can_msgs REQUIRED) it cannot build with rolling.


          fix: use find_package to fix rolling build error

79f960c

Signed-off-by: M. Fatih Cırıt <[email protected]>

xmfcx mentioned this pull request

ci(build_test.yml): update the rolling to noble #44

Merged

Contributor Author

xmfcx commented Mar 26, 2024 •

edited

Loading

Wrong judgement from my side.

It turns out this was coming from rosdep not resolving the package.xml things because I was in Ubuntu jammy and instead was asking for noble.

Instead, opened this PR:

ci(build_test.yml): update the rolling to noble #44

xmfcx closed this

xmfcx deleted the fix/rolling-build-error branch

March 26, 2024 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet