Skip to content
This repository has been archived by the owner on Jul 18, 2020. It is now read-only.

Urgent: Remove breaking createJSModules override #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Urgent: Remove breaking createJSModules override #169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
807a81c
Urgent: Remove breaking createJSModules override
Aug 2, 2017
5002a56
Re-add createJSModules without @Override
Aug 2, 2017
0828a21
Update LockReactPackage.java
Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions android/src/main/java/com/auth0/lock/react/LockReactPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,9 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
return modules;
}

/**
* NOT USED. This is a required override
* @see ReactPackage
*/
@Override
public List<Class<? extends JavaScriptModule>> createJSModules() {
return new ArrayList<>();
// Required @Override for React Native v0.46.x and lower
public List<Class<? extends JavaScriptModule>> createJSModules() {
return new ArrayList<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly you should remove the function entirely.

}

/**
Expand Down