Urgent: Remove breaking createJSModules override #169
Conversation
Parallel change to that required in react-native-auth0: auth0/react-native-auth0#70
- Provides backward compatibility with v0.46.x and earlier
|
Not sure how to read the Travis log - it's quitting b/c the log got too massive, but I don't see errors or exceptions. |
|
It would be great, if this is merged ASAP |
|
+1 |
| return new ArrayList<>(); | ||
| // Required @Override for React Native v0.46.x and lower | ||
| public List<Class<? extends JavaScriptModule>> createJSModules() { | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
honestly you should remove the function entirely.
|
With the function still in there, if anyone upgrades react-native-lock then they'll still have a working build. The function is trivial to leave in, so I'd probably do that. |
|
Is anything happening with this? I'm trying to upgrade to 0.47.0 and hitting the issue described. |
|
@jeaye You may have to just fork and make the change, then point package.json at the custom version. It's pretty easy. Auth0 has given up on this module which really sucks as we're forced onto web-based authentication within the app. Looking at alternate options. I wouldn't hold out hope that this pull request will ever be merged. |
|
@lukecwilliams I can do that. Thanks for the heads up! |
Parallel change to that required in react-native-auth0: auth0/react-native-auth0#70