feat: Enhance the monitor verb syntax #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that only regex-matching notifications are sent - e.g. do not send other 'control' type notifications like the 'statsNotifications' (b) to allow client to indicate that this socket is also being used for request-response interactions test: Add unit tests for MonitorVerbBuilder including round-trip tests from builder to command to builder to command
…he MonitorVerbBuilder in line with guidelines at https://dart.dev/guides/language/effective-dart/documentation
|
Once this PR is closed then we can start working on implementation in the atServer. @cpswan I settled on |
style: Removed an unnecessary use of toString() in MonitorVerbBuilder.buildCommand
|
Related to atsign-foundation/at_server#1259 and atsign-foundation/at_server#1260 |
cpswan
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
feat: Enhanced the
monitorverb syntax (a) to allow client to request that only regex-matching notifications are sent - e.g. do not send other 'control' type notifications like the 'statsNotifications' (b) to allow client to indicate that this socket is also being used for request-response interactions- How I did it
strictandmultiplexedflags to the monitor verb syntax regexstrictandmultiplexedflags to the MonitorVerbBuilder, defaulting to falsegetBuilder(String command)method to MonitorVerbBuilder so can generate a builder from a command and thus do round-trip tests to ensure nothing is being lost- How to verify it
Tests pass