Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supress statsNotification #1259

Open
cpswan opened this issue Mar 15, 2023 · 1 comment
Open

Supress statsNotification #1259

cpswan opened this issue Mar 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@cpswan
Copy link
Member

cpswan commented Mar 15, 2023

Is your feature request related to a problem? Please describe.

When using monitor with a regex to filter for specific notifications the statsNotifications come crashing through and need to be filtered client side

Describe the solution you'd like

Extend the monitor verb to allow supression of statsNotification

Describe alternatives you've considered

Change behaviour so that statsNotification are excluded from regex (unless specifically asked for)

Additional context

Discussed with @gkc on 14/15 Mar 2023
@cpswan cpswan added the enhancement New feature or request label Mar 15, 2023
@cpswan cpswan mentioned this issue Mar 15, 2023
Merged
@gkc
Copy link
Contributor

gkc commented Apr 3, 2023

Moving to triage and unassigning myself as I will not have capacity this sprint

Note that the at_commons work was completed in atsign-foundation/at_tools#301

@gkc gkc removed their assignment Apr 3, 2023
@gkc gkc mentioned this issue Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkc @cpswan