Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at_activate creates atKeys files but in the wrong place. (sshnp v5.5.0 binaries) #629

Closed
cconstab opened this issue Aug 11, 2024 · 3 comments · Fixed by #630
Closed

at_activate creates atKeys files but in the wrong place. (sshnp v5.5.0 binaries) #629

cconstab opened this issue Aug 11, 2024 · 3 comments · Fixed by #630
Assignees
Labels
bug Something isn't working

Comments

@cconstab
Copy link
Member

Describe the bug

when creating a new request for keys the keyfil is created but in a subdirectory and not in the place it should.

Steps to reproduce

C
cconstab@orac:~$ at_activate enroll -s 9DWFF1  -p sshnp   -d orac_ssh_2  -n "sshnp:rw,sshrvd:rw" -a @ssh_1  --keys ~/.atsign/keys/@ssh_1_newkeys
Submitting enrollment request
Enrollment ID: 672e0d46-2e86-443e-8b79-be9d0078fca9
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys/.atKeys

Note [Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys/.atKeys

This should I think read [Success] Your .atKeys file saved at /home/cconstab/.atsign/keys/@ssh_1_newkeys.atKeys

Expected behavior

Keys created in the right place as requested

Screenshots

No response

Smartphones

  • at_activate from v5.5.0 of sshnp

Version : 5.5.0 (core: 6.1.0)

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@cconstab
Copy link
Member Author

cconstab commented Aug 16, 2024

Does this need to be pushed to pub dev?
@sitaram-kalluri

@sitaram-kalluri
Copy link
Member

Does this need to be pushed to pub dev? @sitaram-kalluri

@cconstab : Yes, we need to publish at_onboarding_cli package.

@sitaram-kalluri
Copy link
Member

sitaram-kalluri commented Aug 16, 2024

Tested the changes with noports by adding dependency_overrides for at_onboarding_cli to use git trunk branch and works as expected. Attaching the test log.

sitaram@sitaram-ThinkPad-E14:~/IdeaProjects/atsign/noports/packages/dart/sshnoports$ ./bin/at_activate enroll -s ABC123 -p myapp -d local -n "buzz:rw" -a @sitaram -r vip.ve.atsign.zone -k ~/keys/akam_keys/@sitaram_1_newkeys
Submitting enrollment request
Enrollment ID: dcebb3a6-6a3c-42dd-bce1-27f674605a6b
Waiting for approval; will check every 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  not approved. Will retry in 10 seconds
Checking ...  approved.
Creating atKeys file
[Success] Your .atKeys file saved at /home/sitaram/keys/akam_keys/@sitaram_1_newkeys.atKeys

Publishing the at_onboarding_cli package with version v 1.6.2 which will have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants