Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth_cli enrollment saves non-named atKeys file #601

Closed
Xlin123 opened this issue Jun 26, 2024 · 2 comments
Closed

fix: auth_cli enrollment saves non-named atKeys file #601

Xlin123 opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Xlin123
Copy link
Member

Xlin123 commented Jun 26, 2024

Describe the bug

~/.local/bin/at_activate enroll -a @bagel69 -s passcode-p noports -d apaz -k ~/.atsign/keys/

[Success] Your .atKeys file saved at /home/avlazure/.atsign/keys/.atKeys

Steps to reproduce

Go through the APKAM flow and supply -k with a directory.

Expected behavior

generates either @bagel69_key.atKeys or something along those lines.

@gkc mentioned:

I decided to make -k mandatory because of the dangers inherent in testing situations where the "original" keys are in ~/.atsign/keys and then you accidentally overwrite. I think I added protection so it'll fail if the file exists but it felt safer overall just to make the user conscious of where the keys files would go

Screenshots

No response

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@srieteja
Copy link
Contributor

srieteja commented Aug 5, 2024

waiting for PR review. Carrying it forward to PR93

@srieteja
Copy link
Contributor

Closing this as the same issue is solved in #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants