Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logic to improve atKeys file naming #623

Closed
wants to merge 6 commits into from

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Jul 30, 2024

Closes #601
- What I did

  • validate if the atKeysFilePath provided by the user is a valid file (or) a directory and take necessary action before creating atKeys file.

- How I did it

  • If the atKeysFilePath provided is a directory, create the atKeys file inside that directory
  • If the atKeysFilePath provided is a file but misses the .atKeys suffix, append one

- How to verify it

  • tests on the way

- Description for the changelog

feat: add logic to improve atKeys file naming

@srieteja
Copy link
Contributor Author

Closing this as the same issue is solved in #629

@srieteja srieteja closed this Aug 19, 2024
@srieteja srieteja deleted the fix_atkeys_naming branch August 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: auth_cli enrollment saves non-named atKeys file
1 participant