Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sync verb builder deprecated params #1450

Merged
merged 11 commits into from
Dec 18, 2024
Merged
3 changes: 3 additions & 0 deletions packages/at_client/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# 3.3.1
- fix: isInSync bug fix for apkam connection
- fix: remove deprecated isPaginated param from SyncVerbBuilder in SyncServiceImpl
- build[deps]: Upgraded dependencies for the following packages:
- at_commons to v5.1.2
## 3.3.0
- feat: add the AtClientBindings mixin which was initially added to the
noports_core package but has broader applicability.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class AtClientPreference {
int syncBatchSize = 5;

/// The number of keys to pull from cloud secondary to local secondary in a single call.
int syncPageLimit = 10;
int syncPageLimit = 25;

// Default chunk size for file encryption and decryption
int fileEncryptionChunkSize = 4096;
Expand Down
3 changes: 1 addition & 2 deletions packages/at_client/lib/src/service/sync_service_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -542,9 +542,8 @@ class SyncServiceImpl implements SyncService, AtSignChangeListener {
// Sync verb syntax has to be changed before removing these deprecations
var syncBuilder = SyncVerbBuilder()
..commitId = lastReceivedServerCommitId
..regex = _atClient.getPreferences()!.syncRegex
..limit = _atClient.getPreferences()!.syncPageLimit
..isPaginated = true;
..regex = _atClient.getPreferences()!.syncRegex;
_logger.finer(_logger.getLogMessageWithClientParticulars(
_atClient.getPreferences()!.atClientParticulars,
'syncBuilder ${syncBuilder.buildCommand()}'));
Expand Down
2 changes: 1 addition & 1 deletion packages/at_client/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies:
async: ^2.9.0
at_utf7: ^1.0.0
at_base2e15: ^1.0.0
at_commons: ^5.0.2
at_commons: ^5.1.2
at_utils: ^3.0.19
at_chops: ^2.2.0
at_lookup: ^3.0.49
Expand Down
Loading