Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove sync verb builder deprecated params #1450

Merged
merged 11 commits into from
Dec 18, 2024
Merged

fix: remove sync verb builder deprecated params #1450

merged 11 commits into from
Dec 18, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Dec 11, 2024 •
edited
Loading

- What I did

  • removed setting deprecated params in call to sync verb builder
    - How I did it
  • In sync service impl, removed isPaginated deprecated params in the call to sync verb builder
  • changed default value for syncPageLimit from 10 to 25 in AtClientPreference to reflect the default value 25 in server
    - How to verify it
  • tests should pass

@murali-shris murali-shris mentioned this pull request Dec 11, 2024
Merged
@murali-shris
Copy link
Member Author

murali-shris commented Dec 11, 2024 •
edited
Loading

To be changed to ready for review after publishing at_commons
atsign-foundation/at_libraries#738

@murali-shris murali-shris marked this pull request as ready for review December 12, 2024 06:16
@murali-shris murali-shris mentioned this pull request Dec 18, 2024
Closed
gkc
gkc previously approved these changes Dec 18, 2024
View reviewed changes
@murali-shris murali-shris merged commit 1db2693 into trunk Dec 18, 2024
10 checks passed
@murali-shris murali-shris deleted the sync_builder_remove_deprecated_params branch December 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

@gkc gkc gkc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murali-shris @gkc @sitaram-kalluri