Accept multiple markdown scope names

[burodepeper]

Description of the Change

I made a mistake in #177.

For whatever reason, I wrote a quick patch in my browser, and obviously, this code would never yield anything useful, because it is just silly javascript. The discussion in #185 made me verify my patch. This new patch should actually do something, while I have to admit that I've only verified it via Chrome's console. My test below seems valid enough.

const markdownGrammars = ['source.gfm', 'text.md']

let grammarScopeName = 'text.md'
markdownGrammars.includes(grammarScopeName) // true

grammarScopeName = 'source.js'
markdownGrammars.includes(grammarScopeName) // false

Alternate Designs

Not applicable

Benefits

Not applicable

Possible Drawbacks

Not fully tested from within Atom. This patch wouldn't break anything any further, at least...

Applicable Issues

Not applicable

[rsese]

Thanks for revisiting this @burodepeper!

Would you be able to add a test for this? The team needs tests in general before they can take a look but also to help make sure future changes in the package don't end up breaking your fix 😄

[burodepeper]

Sure! I’ll have a look at it after my Christmas break.

…

On Fri, 21 Dec 2018 at 03:22, Robert Sese ***@***.***> wrote: Thanks for revisiting this @burodepeper <https://github.com/burodepeper>! Would you be able to add a test for this? The team needs tests in general before they can take a look but also to help make sure future changes in the package don't end up breaking your fix 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#186 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADiC6i5pABLgYAZuXW3uGcAnHLBOb7tEks5u7EXcgaJpZM4Za8bU> .