Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCA11Y-1145 Make project releaseable #11

Merged
merged 14 commits into from
Sep 30, 2024

Conversation

atl-mk
Copy link
Collaborator

@atl-mk atl-mk commented Sep 20, 2024

This prepares the POMs to be releaseable in the same manner as we've done for Spring, Velocity, and Selenium forks we own in DC.

@atl-mk
Copy link
Collaborator Author

atl-mk commented Sep 23, 2024

We don't need to change the groupId, we don't do it for our other forks. This has the benefit of being discoverable by the community in Maven repository listing sites and making it easy to use Renovate to suggest replacing existing non-fork with forked versions.

@arymasheusky-atl
Copy link
Collaborator

We don't need to change the groupId, we don't do it for our other forks. This has the benefit of being discoverable by the community in Maven repository listing sites and making it easy to use Renovate to suggest replacing existing non-fork with forked versions.

The benefits make sense, however I have some reservations about the feasibility.

(Internal links follow, sorry.)

First because of the guide at https://hello.atlassian.net/wiki/spaces/OSP/pages/791250012/HOWTO+Publish+an+open+source+project+on+Maven+Central that says

The process outlined above only supports artifacts with a groupId of com.atlassian[.] or io.atlassian[.] because the agreement with Maven Central is only for these namespaces.

Second because the buildeng team emphasized it: https://atlassian.slack.com/archives/CFG89A465/p1726782469523919?thread_ts=1726760008.185449&cid=CFG89A465

... We will not be able to publish the current groupId to maven central.

Third because when I tried to publish the artifact with the current groupId during work on #10, I got an error:

org.apache.maven.artifact.deployer.ArtifactDeploymentException: Failed to deploy artifacts: Could not transfer artifact com.github.eirslett:frontend-plugins:pom:1.15.0-atlassian-testrelease-1 from/to maven-atlassian-com (https://packages.atlassian.com/maven/central): status code: 409, reason phrase:  (409)

But with changed groupId, the error went away.

So my question is - if we do throw away that piece of investigation, how are we making sure that the release will work?

@atl-mk
Copy link
Collaborator Author

atl-mk commented Sep 27, 2024

@arymasheusky-atl
Copy link
Collaborator

Released a hash version https://packages.atlassian.com/maven/3rdparty/com/github/eirslett/frontend-maven-plugin/1.15.0-atlassian-1-e31f82ca/

I'm satisfied with that answer to the "do we need to change groupId?" question, thanks. :)

@arymasheusky-atl arymasheusky-atl merged commit f877a50 into master Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants