Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCA11Y-1222 config changes for releasing to Atlassian repository #10

Closed

Conversation

arymasheusky-atl
Copy link
Collaborator

@arymasheusky-atl arymasheusky-atl commented Sep 20, 2024

Summary
In order to make our changes to the fork available for use in Atlassian projects, we want to publish to the Atlassian package repository.

This PR adds and modifies necessary configuration for that.

I followed this internal guide from the local machine and tried until the deployment succeeded.

Another helpful guide: https://hello.atlassian.net/wiki/spaces/OSP/pages/791250012/HOWTO+Publish+an+open+source+project+on+Maven+Central

  • changed groupId, because our repository mirrors the open-source releases to Maven Central, and we can only use {com|io}.atlassian prefixes for that.
  • added central-pom from https://bitbucket.org/atlassian/parent-poms/ and removed explicit distributionManagement (the values in which additionally were obsolete at this point anyway)
  • removed tagging for the sonatype - some kind of an external registry
  • updated scm section (while there was no harm in keeping atlassian/frontend-maven-plugin because of a redirect, the more correct atlassian-fork/frontend-maven-plugin is used now)
  • removed explicit mentions of maven-source-plugin because the command from the manual (mvn source:jar javadoc:jar install) didn't work with them: that plugin was being called twice and didn't like that
  • removed the skip=true config to the deploy task. I hold a quaint notion that when a guy issues the "deploy" command, he expects the "deploy" command to execute.

Tests and Documentation

With these mentions, the `mvn clean source:jar javadoc:jar install` command
fails with

```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project frontend-plugin-core: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them. -> [Help 1]
```

Without them, it executes fine, and in the local Maven repository I see the
`-javadoc.jar` and `-sources.jar` generated, for both frontend-maven-plugin and
frontend-plugin-core, so I consider removing it to be correct.
We don't want to publish to that repository.
Even though it doesn't matter (there's a redirect from atlassian/fmp to
attlassian-forks/fmp), it's worth it.
Copy link
Collaborator

@flipatlas flipatlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arymasheusky-atl
Copy link
Collaborator Author

Superseded by #11

@arymasheusky-atl arymasheusky-atl deleted the issue/master/DCA11Y-1222-release-for-use-in-aui branch September 30, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants